This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Typo in DWARF_ONE_KNOWN_DW_TAG commit?


commit 7f617347794f7d57f69d08f38c00f3f6ad221a56
Author: Petr Machata <pmachata@redhat.com>
Date:   Wed Mar 18 19:42:02 2015 +0100

    Publish known-dwarf.h

    - Make the macro names properly scoped (DWARF_ALL_KNOWN_* and
      DWARF_ONE_KNOWN_*).

    - Simplify the calling convention: don't keep track of the comment
      associated with the enumerator, always use the non-_DESC
      DWARF_ONE_KNOWN_* callback.

    - Install known-dwarf.h alongside libdw.h and others.

    Signed-off-by: Petr Machata <pmachata@redhat.com>

has

-#define ONE_KNOWN_DW_TAG(NAME, CODE) case CODE: return #NAME;
-      ALL_KNOWN_DW_TAG
-#undef ONE_KNOWN_DW_TAG
+#define DWARF_ONE_KNOWN_DW_TAG(NAME, CODE) case CODE: return #NAME;
+      DWARF_ALL_KNOWN_DW_TAG
+#undef DWARF_ONE_KNOWN_DW_TAG

But DWARF_ONE_KNOWN_DW_TAG is defined, but never used
while DWARF_ALL_KNOWN_DW_TAG is used, but never defined.

-- 
H.J.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]