This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: 0.143 regression failures.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 21 Sep 2009 21:56:45 +0200
- Subject: Re: 0.143 regression failures.
Hi Kurt,
On Mon, 2009-09-21 at 20:35 +0200, Kurt Roeckx wrote:
> 0.143 returns those regression failures for me:
> section [27] '.comment' has wrong flags: expected none, is MERGE|STRINGS
> *** failure in ../src/addr2line
> section [28] '.comment' has wrong flags: expected none, is MERGE|STRINGS
> *** failure in ../src/elfcmp
> section [28] '.comment' has wrong flags: expected none, is MERGE|STRINGS
> *** failure in ../src/elflint
> section [27] '.comment' has wrong flags: expected none, is MERGE|STRINGS
> *** failure in ../src/findtextrel
> section [28] '.comment' has wrong flags: expected none, is MERGE|STRINGS
> [...]
That is most likely because you are using a new binutils/gas which
includes this patch:
2009-07-24 Roland McGrath <roland@redhat.com>
Mark Wielaard <mjw@redhat.com>
* config/obj-elf.c (obj_elf_ident): Set SEC_MERGE | SEC_STRINGS
flags on .comment section.
http://sourceware.org/ml/binutils/2009-07/msg00277.html
I don't know which binutils release that was part of though.
If we want to support that in elflint, then something like the following
patch would be needed:
diff --git a/src/elflint.c b/src/elflint.c
index f85d286..6b79d93 100644
--- a/src/elflint.c
+++ b/src/elflint.c
@@ -3330,7 +3330,7 @@ static const struct
{
/* See figure 4-14 in the gABI. */
{ ".bss", 5, SHT_NOBITS, exact, SHF_ALLOC | SHF_WRITE, 0 },
- { ".comment", 8, SHT_PROGBITS, exact, 0, 0 },
+ { ".comment", 8, SHT_PROGBITS, atleast, 0, SHF_MERGE | SHF_STRINGS },
{ ".data", 6, SHT_PROGBITS, exact, SHF_ALLOC | SHF_WRITE, 0 },
{ ".data1", 7, SHT_PROGBITS, exact, SHF_ALLOC | SHF_WRITE, 0 },
{ ".debug_str", 11, SHT_PROGBITS, exact_or_gnuld, SHF_MERGE | SHF_STRINGS,
Cheers,
Mark