This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move nested functions in core-file.c to file scope.


On Wed, 2015-11-18 at 10:38 -0800, Chih-Hung Hsieh wrote:
> * Move nested functions 'fail', 'update_end', and 'more' to file scope.

Still not a fan of the many arguments functions approach, but in this
case it seems it isn't too bad since there is a clear purpose for the
arguments and the definition and callers of the functions are fairly
close together making it easy to see what is going on.

Pushed to master.

Thanks,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]