This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix uninitialized Dwarf_Frame->regs

From: Roland McGrath <roland at hack dot frob dot com>
To: elfutils-devel at lists dot fedorahosted dot org
Date: Mon, 08 Oct 2012 12:42:18 -0700
Subject: Re: [patch] Fix uninitialized Dwarf_Frame->regs

Use assert rather than just a comment for the reg_unspecified==0
assumption.  Usual style is 'sizeof fs->regs[0]'.  Also, I'd do the
initialization on BIGGER and before 'fs = bigger;' so the assignment
indicates it is ready to use.

OK with those changes.


Thanks,
Roland

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]