Re: [PATCH] Move nested functions in gzip.c to file scope.

[Chih-Hung Hsieh <chh at google dot com>]

I see. Please review attached 0003*patch.
Now fd and start_offset are passed to open_stream.
Thanks.


On Fri, Nov 13, 2015 at 11:30 AM, Mark Wielaard <mjw@redhat.com> wrote:

> On Fri, Nov 13, 2015 at 11:14:10AM -0800, Chih-hung Hsieh wrote:
> > I saw that pread_retry used fd and start_offset with or without
> USE_INFLATE.
> > Is there a way to change that part or should we just leave fd and
> > start_offset in the unzip_state?
>
> I changed that part by just using the fd and start_offset directly instead
> of adding them to the state.
>
> Cheers,
>
> Mark
>

I see. Please review attached 0003*patch.

Now fd and start_offset are passed to open_stream.

Thanks.

On Fri, Nov 13, 2015 at 11:30 AM, Mark Wielaard <mjw@redhat.com> wrote:

On Fri, Nov 13, 2015 at 11:14:10AM -0800, Chih-hung Hsieh wrote:
> I saw that pread_retry used fd and start_offset with or without USE_INFLATE.
> Is there a way to change that part or should we just leave fd and
> start_offset in the unzip_state?

I changed that part by just using the fd and start_offset directly instead
of adding them to the state.

Cheers,

Mark

Attachment: 0003-Move-nested-functions-in-gzip.c-to-file-scope.patch
Description: Binary data