This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Let libelf.h's loff_t fall back to off_t


> > Yeah, that sounds like a wise fear.  But maybe Elf64_Off is OK (and
> > preferable even) for the cases that are not return values?
> 
> In practice we're limited to 2^63-1 off_t anyway, so the only benefit
> would be enforcing that they can't be negative, right?

And the types being sane for the purposes they actually have.

> I dunno, seems like a small benefit that still has a chance to perturb
> users.  Even just say Elf_Data.d_off comparisons may lead to "comparing
> signed and unsigned" warnings if we change our part, and I know I like
> -Werror in my builds.

I hear you.  But in reality I doubt there is any code like that.
However, I don't really have strong feelings about this.
Just avoiding a configure-generated header makes me pretty happy.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]