Re: pmachata/reader_hooks branch

[Petr Machata <pmachata at redhat dot com>]

Ulrich Drepper wrote:
> Petr Machata wrote:
>> On x86_64, -O1 through -O3, overall change in .text is 2%.  Sizes of
>> particular functions change thus on -O2:
>> [...]
> 
> Did you add something to the hook functions similar to what will be
> there later on?  I.e., as Roland said
> 
>    if (SOMETHING)
>      return SOMEFUNC();
> 
> This is the real test since this is the ultimate goal of this change.

Right.  With two fancy_business functions added (for offset and for 
address) and called conditionally on a new, always-zero field from 
struct Dwarf, the metrics on x86_64, -O2 build, change thus:

dwarf_formaddr           	126	366	+240	2.90
dwarf_formref_die        	200	463	+263	2.31
dwarf_formstring         	162	437	+275	2.70
dwarf_formudata          	389	678	+289	1.74
dwarf_getaranges         	1144	1700	+556	1.49
dwarf_getlocation        	115	118	+3	1.03
dwarf_getlocation_addr   	1117	948	-169	0.85
dwarf_getpubnames        	1247	1506	+259	1.21
dwarf_getsrclines        	5358	5428	+70	1.01
dwarf_nextcu             	453	763	+310	1.68
dwarf_ranges             	694	797	+103	1.15
getlocation              	1585	1924	+339	1.21

Total change in .text is then 2.9%.

PM

Attachment: signature.asc
Description: PGP signature