This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 1/5] Rewrite DWARF string functions using known-dwarf macros.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 14 Aug 2012 21:43:22 +0200
- Subject: Re: [PATCH 1/5] Rewrite DWARF string functions using known-dwarf macros.
On Tue, 2012-08-14 at 11:24 -0700, Roland McGrath wrote:
> I still don't like "unknown_%#x" vs just plain "%#x". I don't understand
> why you prefer it.
Sorry I thought I had explained. I don't like just the plain hex number
since that doesn't signal something is wrong. Using the lower case
unknown_ prefix matches the lo_user+ prefix which also signals something
is wrong. The user should know this is not an ordinary case, either the
DWARF they are inspecting is bogus or their elfutils version hasn't been
updated for their toolchain. In the normal case there should be no
lo_user+/unknown_ values in any output.
I had considered using UNKNOWN in all caps but thought it was too much,
or just use quotes around the hex value, but that seemed to not really
show that something was wrong. Would any of those alterations, or a
variation on them, make you happy?
Thanks,
Mark