This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
[PATCH] ldlex: Fix sign-compare warning, suppress -Wstack-usage.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 07 Oct 2015 13:59:55 +0200
- Subject: [PATCH] ldlex: Fix sign-compare warning, suppress -Wstack-usage.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
src/ChangeLog | 5 +++++
src/Makefile.am | 1 +
src/ldlex.l | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index daa76cf..3f9b281 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-07 Mark Wielaard <mjw@redhat.com>
+
+ * Makefile.am (ldlex_no_Wstack_usage): New.
+ * ldlex.l ([RWX]): Make cnt unsigned.
+
2015-10-05 Josh Stone <jistone@redhat.com>
* Makefile.am (libld_elf_i386.so): Add AM_V_CCLD silencer.
diff --git a/src/Makefile.am b/src/Makefile.am
index afb38fc..04ae3cb 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -89,6 +89,7 @@ endif
# XXX While the file is not finished, don't warn about this
ldgeneric_no_Wunused = yes
ldgeneric_no_Wstack_usage = yes
+ldlex_no_Wstack_usage = yes
# Bad, bad stack usage...
readelf_no_Wstack_usage = yes
diff --git a/src/ldlex.l b/src/ldlex.l
index bfc8bbe..835c2dc 100644
--- a/src/ldlex.l
+++ b/src/ldlex.l
@@ -146,7 +146,7 @@ SIZEOF_HEADERS { return kSIZEOF_HEADERS; }
SORT { return kSORT; }
VERSION { return kVERSION; }
-"["([RWX]){0,3}"]" { int cnt = 1 ;
+"["([RWX]){0,3}"]" { unsigned int cnt = 1 ;
ldlval.num = 0;
while (cnt < yyleng - 1)
ldlval.num |= attrib_convert (yytext[cnt++]);
--
2.4.3