Re: make the shared library optional

[Mark Wielaard <mjw at redhat dot com>]

On Mon, 2014-11-10 at 16:49 +0000, Vicente Olivert Riera wrote:
> On 11/08/2014 03:14 PM, Mark Wielaard wrote:
> >>> It looks like that is a fairly old 0.155 build with several patches
> >>> applied. Have you tried latest elfutils 0.160 or current git?
> >>
> >> I have tried elfutils-0.160, but I'm having this error:
> >>
> >> /br/output/host/usr/bin/mipsel-linux-gcc -D_GNU_SOURCE -DHAVE_CONFIG_H
> >> -DLOCALEDIR='"/usr/share/locale"' -I. -I..  -I. -I. -I../lib -I..
> >> -I./../libelf -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -std=gnu99 -Wall
> >> -Wshadow -Werror -Wunused -Wextra -fgnu89-inline -Wformat=2   -fpic
> >> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -pipe -Os -g2 -static -c -o
> >> color.o color.c
> >> color.c: In function ‘parse_opt’:
> >> color.c:135:5: error: passing argument 4 of ‘argp_help’ discards ‘const’
> >> qualifier from pointer target type [-Werror]
> >>      program_invocation_short_name);
> >>      ^
> >> In file included from color.c:34:0:
> >> /home/ldap/vriera/work/mips-buildroots/mips32/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/include/argp.h:469:13:
> >> note: expected ‘char *’ but argument is of type ‘const char *’
> >>  extern void argp_help (__const struct argp *__restrict __argp,
> >>              ^
> >> cc1: all warnings being treated as errors
> >> make[3]: *** [color.o] Error 1
> > 
> > That is strange. argp_help does indeed take a non-const char *.
> > But program_invocation_short_name is defined as non-const char * too
> > in errno.h. You might be using a non-GNU glibc? Some libcs are slightly
> > broken.
> 
> It's uClibc.

Yeah, that seems to be the problem.
glibc errno.h defines:
extern char *program_invocation_name, *program_invocation_short_name;
While uClibc has:
extern const char *program_invocation_name,
*program_invocation_short_name;

If you fix uClibc errno.h to drop the const in these definitions the
code will compile as is.

Thanks,

Mark