Re: [PATCH] stack: -b, --build-id shows module build-id, load address and pc offset.

[Mark Wielaard <mjw at redhat dot com>]

On Thu, Jan 02, 2014 at 09:14:28PM +0100, Jan Kratochvil wrote:
> On Mon, 23 Dec 2013 11:21:52 +0100, Mark Wielaard wrote:
> [...]
> > +	    {
> > +	      printf ("\n    [");
> > +	      do
> > +		printf ("%02" PRIx8, *id++);
> > +	      while (--id_len > 0);
> > +	      printf ("]@0x%0" PRIx64 "+%" PRIx64, start, pc_adjusted - start);
> why not:
>    	      printf ("]@0x%0" PRIx64 "+0x%" PRIx64, start, pc_adjusted - start);
> > +	    }
> 
> Example output:
> #63 0x000000000040054e bt
>     [dc2908a524b82c19b6f26e66803193d54d394b33]@0x400000+54d
> why not:
>     [dc2908a524b82c19b6f26e66803193d54d394b33]@0x400000+0x54d
> 
> I would find it easier to handle by copy-pastes, for example for address
> computations in GDB (or what other tool people use for computing addresseS).

Agreed that is a better looking and more consistent output.

Thanks,

Mark

Attachment: 0001-stack.c-print_frames-Print-0x-before-build-id-hex-of.patch
Description: Text document