This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 12/17] libdwfl: Reject very short or really large build-ids.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 27 May 2015 22:52:05 +0200
- Subject: Re: [PATCH 12/17] libdwfl: Reject very short or really large build-ids.
On Tue, May 26, 2015 at 12:41:52PM -0700, Roland McGrath wrote:
> Put the limit in a macro.
Done.
> As specified, there is no limit on the size of a build ID. So this is
> imposing an implementation limit. That limit is certainly going to be fine
> in practice, but it is a gratuitous arbitrary limit.
Yeah. Currently all build IDs are a 160 bit (20 byte) hash. I think a
512 bit (64 byte) hash is the maximum anybody will ever realistically use.
It is more likely that the paths the build-id link files are stored at
will change before the number of build ID bytes is increased that much.
Cheers,
Mark