This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 1/2] Initialize type_offset of fake_cu
- From: Mark Wielaard <mark at klomp dot org>
- To: Ulf Hermann <ulf dot hermann at qt dot io>, elfutils-devel at sourceware dot org
- Date: Tue, 19 Sep 2017 16:52:33 +0200
- Subject: Re: [PATCH 1/2] Initialize type_offset of fake_cu
- Authentication-results: sourceware.org; auth=none
- References: <47e9193b-bfb3-a652-de71-ebea8c566c4b@qt.io> <2f0433b3-f16c-41f4-bfad-2e3d004cea29@qt.io>
On Wed, 2017-09-06 at 12:38 +0200, Ulf Hermann wrote:
> On 05/09/2017 06:28 PM, Ulf Hermann wrote:
> > Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
> > ---
> > libdw/ChangeLog | 4 ++++
> > libdw/dwarf_getmacros.c | 1 +
> > 2 files changed, 5 insertions(+)
> > [...]
>
> It seems we missed this one, but it fixes a bug. Can we apply it?
> PATCH 2/2 is not actually related.
I assume you mean this patch:
> diff --git a/libdw/dwarf_getmacros.c b/libdw/dwarf_getmacros.c
> index eb50508..9e2a4a1 100644
> --- a/libdw/dwarf_getmacros.c
> +++ b/libdw/dwarf_getmacros.c
> @@ -361,6 +361,7 @@ read_macros (Dwarf *dbg, int sec_index,
> .offset_size = table->is_64bit ? 8 : 4,
> .startp = (void *) startp + offset,
> .endp = (void *) endp,
> + .type_offset = 0,
> };
>
> Dwarf_Attribute *attributes;
That really shouldn't be necessary. In a named struct field initializer
omitted elements are initialized to zero. Are you sure it fixes a real
bug? In that case it might be a compiler bug instead (which we would
want to work around, but then lets make sure to report it and add a
comment).
Cheers,
Mark