This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 3/5] Add frame pointer unwinding as fallback on x86_64
- From: Ulf Hermann <ulf dot hermann at qt dot io>
- To: Mark Wielaard <mark at klomp dot org>, <elfutils-devel at sourceware dot org>
- Date: Tue, 25 Apr 2017 14:56:10 +0200
- Subject: Re: [PATCH 3/5] Add frame pointer unwinding as fallback on x86_64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KdDwbDKHACqRmidOTbIlMJ58qte+/3ldNYv82o0K81g=; b=DIhOcZ5T+IibwnkPJde4sUM8CNERFZfF1cYFbjoKpDDUOE6o4I1+vOjJXdUqJwfP+6gTguKmsXor5k/qUyXhWlBbF2uGSmw4jU0C+Vzjysk99NW7QUKpmOn64/NPPvPE45oH94RjOePJswpo7/Tke+DcZ+ZEA333R2JqTJMrr4c=
- References: <1493124006.31726.33.camel@klomp.org> <1493124579-21017-1-git-send-email-mark@klomp.org> <1493124579-21017-3-git-send-email-mark@klomp.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 04/25/2017 02:49 PM, Mark Wielaard wrote:
> From: Ulf Hermann <ulf.hermann@qt.io>
>
> If we don't find any debug information for a given frame, we usually
> cannot unwind any further. However, the binary in question might have
> been compiled with frame pointers, in which case we can look up the
> well known frame pointer locations in the stack snapshot and use them
> to bridge the frames without debug information.
>
> The "unwind" hook is the right place for this as it is so far only
> used on s390 and called only after trying to unwind with debug
> information.
Looks good to me.
Ulf