This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board.


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219

--- Comment #45 from Ilija Kocho <ilijak@siva.com.mk> 2012-12-28 14:15:27 GMT ---
Jerzy

(In reply to comment #44)

[snip]

> 
> Should I correct something or regenerate patch split into parts or
> patch in current state is acceptable?

In addition to points 1..3 mentioned in comment 43:

4. Check naming of CDLs. For instance CYGNUM_DEVS_ETH_CORTEXM_STM32_INTF is not
numerical. Likewise CYGNUM_DEVS_ETH_CORTEXM_STM32_REMAP_PINS and some others.
You shall find CDL naming convention at
http://ecos.sourceware.org/docs-latest/cdl-guide/language.naming.html.

5. There are some lines longer than 78 char. Not too much longer (couple of
char is not a problem, but check them.

6. Clean up trailing spaces.

7. Update the copyright banners (now is 2012 and soon 2013).
8. Likewise ChangeLog(s).

Happy New 2013
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]