This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
[Bug 1000910] New port: Ethernet over SPI driver for ENC424J600
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Fri, 4 May 2012 17:35:57 +0100
- Subject: [Bug 1000910] New port: Ethernet over SPI driver for ENC424J600
- Auto-submitted: auto-generated
- References: <bug-1000910-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000910
--- Comment #21 from Jonathan Larmour <jifl@ecoscentric.com> 2012-05-04 17:35:48 BST ---
I have made a bunch of cosmetic updates and applied the patch, thanks! I will
attach the updated version of the patch, along with the updates themselves. A
lot of them were just whitespace changes, most especially in the CDL file. It
now conforms to our existing practice much better, and in future you may want
to watch out for the sort of things I changed if you submit patches in future.
There are a few other textual changes too, and some fixes of changing things
like cdl_components which should really be cdl_options. But nothing of great
importance.
Note, despite the earlier discussion, I have in the end changed the description
of CYGHWR_HAL_CORTEXM_STM32_SPIETH_CONTROLLER because I realised that in the
configuration tool, if the CYGPKG_DEVS_ETH_ENC424J600 package is not loaded,
the package will be displayed at the top level, albeit inactive. With a title
of just "STM3210E HAL resources", this might confuse some people.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.