This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Mon, 17 Oct 2011 23:25:18 +0100
- Subject: [Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)
- Auto-submitted: auto-generated
- References: <bug-1001187-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187
--- Comment #23 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-17 23:25:15 BST ---
Hi Sergei
Thank you for jumping in.
(In reply to comment #21)
> Jifl> Nothing else leapt out at me. It seems a very good quality patch
> Jifl> from what I can tell.
>
> Totally agree. That's very solid code. It looks great.
>
> Nothing of importance can add. Only if view under a microscope :-)
Perfection is when there's nothing to take out.
(Antoine de Saint-ExupÃry)
>
> Infusoria:
>
> Ilija, if you will send some corrections, also, you would get rid the
> trailing whitespaces (mostly in CDL) and expand a few tabs in ethernet
Recently I have installed a macro in my editor [me] that removes trailing
whitespace prior to saving. I hope new files shall come cleaner.
> driver, also, I would get rid such shorthands
>
> }while(need_service);
I will try to find more appropriate term. Maybe: "need_delivery"
"pending_delivery"...
>
> there. And
>
> wallclock:
> +# Date: 2011.04.23
Changed.
CU
Ilija
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.