[Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board.

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-08 15:02:21 BST ---
Hi Jerzy

Thank you for your contribution. Here are my first remarks:

1. Some unresolved conflicts remain upon Propox board selection in Configtool
and it may mislead the user that something is broken. It seems that Configtool
can't resolve the CYGHWR_HAL_CORTEXM_STM32_CLOCK_PLL_SOURCE on it's own so
let's make it little-bit easier:
  -  Is it possible to re-arrange legal_values expression in order to make it
easier for Configtool?
  - Or it is better to calculate default_value conditionally
(CYGINT_HAL_CORTEXM_STM32_CL==0 ?)

2. CYGPKG_IO_ETH_DRIVERS is normally not included in the target. Not everybody
would use Ethernet. Please remove it.

3. FYI, the PHY driver DP8348 has been resolved in meantime by Bug 1001235.
Please synchronize your code with it.

Now some general hints: It usually takes a number of iterations before code is
fit for commit and it would be easier for me (hopefully also for you) if you
break the patch in several diffs (divide and conquer). Ideally - a diff for
every affected package, in this case: /eth driver/, /variant/, /platform/ and
eventually /phy driver/. As exception ecos.db is better not sent as diff,
instead put your ecos.db entries in a plain file and name it ecos_db.txt .

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.