This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: bugfix in ethernet driver for the arm at91 variant: if_at91.c
- From: Sergei Gavrikov <sergei dot gavrikov at gmail dot com>
- To: Bob Brusa <bob dot brusa at gmail dot com>
- Cc: "ecos-patches at sources dot redhat dot com" <ecos-patches at sources dot redhat dot com>
- Date: Mon, 15 Feb 2010 19:44:02 +0200
- Subject: Re: bugfix in ethernet driver for the arm at91 variant: if_at91.c
- References: <op.u6irvlhn8qukij@w27> <op.u76grls98qukij@w27>
Bob Brusa wrote:
> Hi
> This repeats a patch handed in already on 14-Jan-2010. But the epk-file
> then used does not correspond to the desired format. So I switched over to
> a textfile, obtained from a diff (see further down).
>
> But back to the problem:
> I found a bug in the v3_0 eth-driver if_at91.c. It is in the handling of
> the buffer-to-list copy in routine at91_eth_recv. Actually, it only treats
> the first list and leaves all "higher" ones empty, thereby loosing data in
> packages that exceed the length of a single list.
[snip]
> Sorry, I found that the last my.patch sent included double entries
> and other "nonconformances". This latest version of the attached
> my.patch file is clean now:
> No double entries
> No tabs but spaces
> No cr-lf, lf only
Thanks,
I'll take a look, but, as I said I would wait a while for the Jürgen's
fixes too to know about the possible interception/union boundaries for
the both workarounds. And I very hope on that you help to provide a
testing on the target then, because, I have not the same hardware.
Sergei
--