This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: memjoin.inl tripwires
- From: "Øyvind Harboe" <oyvind dot harboe at zylin dot com>
- To: "Jonathan Larmour" <jifl at ecoscentric dot com>
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Fri, 21 Dec 2007 18:34:30 +0100
- Subject: Re: memjoin.inl tripwires
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=toDkvuOtS0xm/Ml0xvEFLRMKsnkQUXWwDlC2BvddrrE=; b=L+6y3RnvxGfA88K869bKPzbQs2XT3Y+bBLJSQT7YFWuIO9aAZ/HW1OjMeCewjImehmaRF/a13fj1cqmpbsBHFtcUypJxd8Ue6dVqiV0scO79FAnE6VSkq7oh5GorJbWXiao9bY3Wc8zHYNX4W0r9aUbxGyfzDFetIBTXV7ZptCM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=d/rySppxhpbl6sLfIDHV5EZd/k3ZjNgOS1XtVWSHVNvDrjgQ1hcoR2jkjA8TuV0CVKYlGqDRFuLqlCW43aI9Mb+zR/rbqXL4k/+O9jf7lOJdtNXC192S7BLTZwXOX5DHhoEUU1src0wqZlmPCYqnrzkp5wsY4920K7gPTc2aiFs=
- References: <c09652430712140223u78b09c52ifed42f31ece3b36b@mail.gmail.com> <476BEAB1.5060900@eCosCentric.com>
On Dec 21, 2007 5:32 PM, Jonathan Larmour <jifl@ecoscentric.com> wrote:
> Øyvind Harboe wrote:
> > I duplicated memjoin.inl and modified it for my own needs. Attached are
> > some backported, untested, changes in case someone feels the urge
> > to test & report on them.
>
> You are using a system with more than 255 memory pools?
No. Two.
>
> If it's just a case of "what if", then I can just add an assert in instead.
The code is broken for two pools.
>
> The rest of the patch is ok (although the changelog does not reflect the
> other changes) and I'll commit it if you can confirm there really is a
> demand for >255 pools!
byte arithmetic is *slower* than cpu word length. Why use anything
but the natural width arithmetic?
>
> Jifl
> --
> eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
> Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
> Registered in England and Wales: Reg No 4422071.
> ------["Si fractum non sit, noli id reficere"]------ Opinions==mine
>
--
Øyvind Harboe
http://www.zylin.com - eCos ARM & FPGA developer kit