This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: memjoin.inl tripwires


On Dec 21, 2007 5:32 PM, Jonathan Larmour <jifl@ecoscentric.com> wrote:
> Øyvind Harboe wrote:
> > I duplicated memjoin.inl and modified it for my own needs. Attached are
> > some backported, untested, changes in case someone feels the urge
> > to test & report on them.
>
> You are using a system with more than 255 memory pools?

No. Two.

>
> If it's just a case of "what if", then I can just add an assert in instead.

The code is broken for two pools.

>
> The rest of the patch is ok (although the changelog does not reflect the
> other changes) and I'll commit it if you can confirm there really is a
> demand for >255 pools!

byte arithmetic is *slower* than cpu word length. Why use anything
but the natural width arithmetic?

>
> Jifl
> --
> eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
> Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
> Registered in England and Wales: Reg No 4422071.
> ------["Si fractum non sit, noli id reficere"]------       Opinions==mine
>



-- 
Øyvind Harboe
http://www.zylin.com - eCos ARM & FPGA  developer kit


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]