This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: romfs fix take #2
- From: "Øyvind Harboe" <oyvind dot harboe at zylin dot com>
- To: "Jonathan Larmour" <jifl at ecoscentric dot com>
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Wed, 14 Nov 2007 15:17:41 +0100
- Subject: Re: romfs fix take #2
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=7uE/TnZCfApTPDoDlcx/jkqT3Px3PAEE1snO0SfsVLg=; b=NVUCAZIkgYRQN+Q3JAacbnigfcjferXo+0Vo97FD2DFC3MfQA3wXI4ehV5wd4ZJtfS14eCilM/0AMUbIoeu316LfaUsCdcoTsd0kzsqCd1AT+9PM+xeOEWRvp1+BiCEJpvRs8jvcBwPN1v5+4noby1NevmseWSYeea3CGF/o/bs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=jp2beRLjdcyndrmXeHRe4QhrMqznYuIxWh6I6yhJN9lLOr/b4rD+Nfwt0r2yaO3PyGy7q9Nd/oQsndNjoxjPUjo37uzhhxYEVjfRihSll3mtEeUi/Kh9OFlIYsS5VgYaYr1XuZ9yup/pU21SeubBDW+43NH7Dln4vYSRDaVBjz4=
- References: <c09652430711132345x542d6655ia1a0c8738ce93e37@mail.gmail.com> <473B01A4.8070708@eCosCentric.com>
On Nov 14, 2007 3:09 PM, Jonathan Larmour <jifl@ecoscentric.com> wrote:
> Øyvind Harboe wrote:
> >
> > append result "/* This is a generated file. Do not edit. */\n\n"
> > -append result "static const unsigned char filedata\[\] = {\n"
> > +append result "static CYGBLD_ATTRIB_ALIGN(4) const unsigned char filedata\[\] = {\n"
>
> Thanks. Patch duly applied, although I'm a little uneasy about hard-coding
> 4. It's probably pedantic to make a fuss about it though so I've kept it.
Agreed. However, this script is duplicated and specific to romfs where
4 is poured in concrete anyway....
I'd rather worry about the other places where that tcl script is used...
--
Øyvind Harboe
http://www.zylin.com - eCos ARM & FPGA developer kit