This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: Patch for Dallas DS12887 regarding Intel PC architectures
- From: Jonathan Larmour <jifl at eCosCentric dot com>
- To: dfernandez at cct dot co dot uk
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Thu, 23 Nov 2006 13:58:51 +0000
- Subject: Re: Patch for Dallas DS12887 regarding Intel PC architectures
- References: <1164281607.8511.2.camel@software.cct.co.uk>
David Fernandez wrote:
Hi there,
This fixes a small bug that causes NMIs being disabled or enabled in PCs
when using this device.
We should avoid introducing changes #ifdeffed for specific targets in
generic code, especially so in this case when it's avoidable.
We should allow an override of DS_READ/DS_WRITE so that
devs/wallclock/i386/pc/current/include/devices_wallclock_i386_pc.inl can
set its own DS_READ/DS_WRITE. A patch that did this would be great, thanks.
Jifl
--
eCosCentric http://www.eCosCentric.com/ The eCos and RedBoot experts
------["The best things in life aren't things."]------ Opinions==mine