This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: workspace_size unused


On Fri, May 28, 2004 at 06:29:14PM +0300, Jani Monoses wrote:
> Hello
> 
> if nobody objects I'll commit this on Monday
> workspace_size seems to be a leftover from old code.

I thought somebody had submitted a patch like this before. So either
it got lost before being committed, or there was a reason not to
commit it.

Gary should OK this patch.

        Andrew

> 
> Jani
> 

> --- orig/packages/redboot/current/include/redboot.h
> +++ mod/packages/redboot/current/include/redboot.h
> @@ -89,7 +89,6 @@
>  EXTERN bool valid_address(unsigned char *addr);
>  EXTERN void cyg_plf_memory_segment(int seg, unsigned char **start, unsigned char **end);
>  EXTERN unsigned char *workspace_start, *workspace_end;
> -EXTERN unsigned long workspace_size;
>  
>  // Data squirreled away after a load operation
>  EXTERN unsigned long entry_address;
> 
> 
> --- orig/packages/redboot/current/src/main.c
> +++ mod/packages/redboot/current/src/main.c
> @@ -286,18 +286,15 @@
>  #ifdef CYGMEM_SECTION_heap1
>      workspace_start = (unsigned char *)CYGMEM_SECTION_heap1;
>      workspace_end = (unsigned char *)(CYGMEM_SECTION_heap1+CYGMEM_SECTION_heap1_SIZE);
> -    workspace_size = CYGMEM_SECTION_heap1_SIZE;
>  #else
>      workspace_start = (unsigned char *)CYGMEM_REGION_ram;
>      workspace_end = (unsigned char *)(CYGMEM_REGION_ram+CYGMEM_REGION_ram_SIZE);
> -    workspace_size = CYGMEM_REGION_ram_SIZE;
>  #endif
>  
>      if ( ram_end < workspace_end ) {
>          // when *less* SDRAM is installed than the possible maximum,
>          // but the heap1 region remains greater...
>          workspace_end = ram_end;
> -        workspace_size = workspace_end - workspace_start;
>      }
>  
>      // Nothing has ever been loaded into memory


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]