This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Fix in quicc2/fcc eth drivers
- From: Gary Thomas <gary at chez-thomas dot org>
- To: Christoph Csebits <christoph dot csebits at frequentis dot com>
- Cc: eCos patches <ecos-patches at ecos dot sourceware dot org>
- Date: Wed, 04 Feb 2004 07:14:09 -0700
- Subject: Re: Fix in quicc2/fcc eth drivers
- References: <20040203151014.A29967@frequentis.com> <1075903861.27984.23.camel@hermes>
On Wed, 2004-02-04 at 07:11, Gary Thomas wrote:
> On Tue, 2004-02-03 at 07:10, Christoph Csebits wrote:
> > hi
> >
> > here is a patch for the quicc2 and for the fcc
> > eth drivers (powerpc architecture).
> >
> > Under heavy load (tx path) the ip stack didn't recover
> > from "out of mbufs". To verify this, just do a
> > udpblast -p 4444 10.14.0.2 9999
> > (where port 4444 is not open).
> >
> > *_eth_can_send() in principle checks if there
> > is a free hardware buffer. But it checked
> > only if the buffer was sent by the
> > hardware. But not if the buffer was
> > also freed up by the upper layer (with txdone).
> >
> > BTW: this patch is also recommended for the FCC:
> > http://sources.redhat.com/ml/ecos-patches/2003-04/txt00002.txt
> > (discard packets with errors (e.g. CRC ))
>
> What platform are you using these drivers for?
>
> The devs/eth/powerpc/quicc2 package is deprecated - replaced by
> .../fcc and platform specific packages. I'd rather see the changes
> made there.
Sorry, I see that you provided patches for both. These will be
committed.
I'll look at your changes from April and see about those as well.
--
Gary Thomas <gary@chez-thomas.org>