This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: romfs_mount wrongly returns ENOENT under certain conditions.


On Thu, Dec 11, 2003 at 02:23:07PM +0530, sandeep wrote:
> Changelog :
> * src/romfs.c (romfs_mount) : function wrongly returns ENOENT even if
> fste->data isn't NULL.
> 
> Problem :
>   if ( !disk ) {
>       // If still no address, try the FSTAB entry data word
> -- mte->data = fste->data;
> ++ disk = (romfs_disk *)fste->data;
>   }
> 
>   if ( !disk ) {
>       // If still no address, give up...
>       return ENOENT;
>   }
> 
> you will wrongly return ENOENT if disk happened to be NULL at the time of first
> if-check though fste->data isn't NULL. attached patch corrects it.

I've committed this patch,
     Thanks
        Andrew



     

Attachment: romfs.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]