This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, 2002-08-27 at 15:47, Nick Garnett wrote: > NavEcos <ecos@navosha.com> writes: > > > Here are the patches to add the following functions to the KAPI: > > > > void cyg_alarm_set_callback( > > cyg_handle_t alarm, > > cyg_alarm_t *alarmfn /* new alarm callback function */ > > ); > > > > cyg_alarm_t *cyg_alarm_get_callback( cyg_handle_t alarm ); > > > > > > This will make alarms more compatible with vxWorks' watch dog functions > > and make it easier to port from vxWorks to eCos. > > > > This is such a trivial change that I'm hoping that we can forgo a > > copyright assignment, although my company will be sending a copyright > > assignment to you guys eventually for other changes that we think will > > be useful to the community at large. > > > > The diffs were tested with the KAPI interface. > > > > There is just one thing I would change. > > The functions should set, and return, both the alarm function and the > data value that goes with it. If the function is changed it is likely > that the data will need to change too. *cough*. My that was incredibly stupid of me wasn't it? I decided to retrieve the values of the alarm callback function and data that accompanies it as 2 separate functions to avoid pointers. If you would rather have it as a single call, let me know and I'll fix it. Here are the prototypes now: void cyg_alarm_set_callback( cyg_handle_t alarm, cyg_alarm_t *alarmfn, /* new alarm callback function */ cyg_addrword_t data /* new alarm callback data */ ); cyg_alarm_t *cyg_alarm_get_callback( cyg_handle_t alarm ); cyg_addrword_t cyg_alarm_get_data( cyg_handle_t alarm ); They have been minimally tested. Attached are the diffs. Thank you, -Rich > -- > Nick Garnett - eCos Kernel Architect > http://www.eCosCentric.com/ >
Attachment:
diff.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |