Re: Redboot jumb patch

[Andrew Lunn <andrew dot lunn at ascom dot ch>]

On Mon, Aug 05, 2002 at 10:13:47AM -0600, Gary Thomas wrote:
> On Mon, 2002-08-05 at 09:12, Andrew Lunn wrote:
> > Hi Folks
> > 
> > Here is a patch for redboot. I needed to make redboot smaller so that
> > i could squeeze it into the same space an older, less feature rich
> > version used. I've made more of the commands conditional
> > compilable. Being able to leave out xzymodem when using networking
> > helps a lot. The linker then leaves out all the crc16 code which has a
> > big table etc. Unless you are running linux, the exec command is a
> > waste of space so i've also made is possible to disabled that. Thats
> > was not so easy since each HAL provides this command. I had to modify
> > quite a few HALs.
> 
> I don't understand your changes.  Most (if not all) of the HALs have
> something like this (in their CDL) for enabling/disabling the Linux
> boot code:

The problem is that is all very inconsistent and spread out. It took
me ages just to find the exec code. I could see the symbols in the
image, but not find the sources in the redboot package. I ended up
grep'ing the entire source tree. 

The same applies for the CDL to control it. Its in the HAL, not
redboot where you would expect it to be. My patch may be redundant in
some cases, but it puts the simple enable/disable in redboot and is
consistent across platforms and with all the other commands in redboot.

> Can you check your patches against the current (trunk) CVS and make sure
> that there is not already CDL in place to handle the Linux boot stuff?

I may do this. I think its more work than needed, since i will end up
renaming lots of things to make then consistent. Also, i have no way
of testing the changes, except to see if they compile.

   Andrew