This is the mail archive of the
ecos-discuss@sourceware.org
mailing list for the eCos project.
Re: Re: Improving TFTP performance
Andrew Lunn wrote:
> On Wed, Dec 19, 2007 at 03:47:32PM +0100, ?yvind Harboe wrote:
>> On Dec 19, 2007 3:17 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>>>> + cdl_option CYGPKG_NET_TFTPD_CLIENT_GET_PACKETSIZE {
>>>> + display "TFTP protocol allows negotiation of bigger packets.
>>>> + Requires server which supports RFC 2348 blksize negotiation."
>>>> + flavor data
>>>> + default_value 512
>>>> + legal_values 512 to 65464
>>>> + description "
>>>> + tftp blksize egotiation support. >512 byte block sizes improves
>>>> + tftp GET performance"
>>>> + }
>>> The display should be kept to one line maximum. Put all the rest on
>>> the description lines. You should also say that the default value of
>>> 512 causes this to be disabled. It might even be better to change the
>>> flavor of this to booldata, so it can be enabled/disabled and the
>>> value set. It then makes your code cleaner.
>> I fought w/booldata for a bit, but couldn't make sense of it.
>
> Something like this is O.K.
>
> cdl_component CYGOPY_NET_TFTPD_CLIENT_BIG_PACKET {
> display "Extension to allow negotiation of big packets"
> flavor bool
> default_value 0
>
> description "Implements RFC XXXX, an optional extension to the TFTP
> protocol to allow the client and server to negotiate
> to use bigger packets. This can make upload/download
> faster"
>
> cdl_option CYGOPY_NET_TFTPD_CLIENT_BIG_PACKET {
> display "Packet size to negotiate"
> flavor data
> default_value 32768
> legal_values 8 to 65535
> description "
> Size of the packets to negotiate. In an error free
> environment, bigger packets will result in faster transfers."
> }
> }
>
>
> This will make your code cleaner. You no longer need the hard coded > 512
> etc.
CYGOPY_??? AFAIK, this isn't one of our normal prefixes (and for namespace
pollution issues, we _try_ to remain consistent). Maybe you want CYGOPT_???
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss