This is the mail archive of the ecos-discuss@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: AT91 Serial Receive: asserts when buffer fills up


On Thu, May 31, 2007 at 03:20:21PM -0700, Jim Seymour wrote:
> In the serial DSR in at91_serial.c, there is a CYG_FAIL() macro if the 
> receive buffer fills up.  (Line #612)
> 
> Is this appropriate?  We like to run with asserts turned on (at least 
> during development), but in our application, overflowing the receive 
> buffer is not that big of a deal.
> 
> It appears that all the other serial drivers quietly throw away 
> characters if their receive buffer is full.  Any complaints if I submit 
> a patch to do the same in the AT91 driver?

"all other" equates to just the sh/scif driver. At the moment there
are only two drivers to do block transfers, the AT91 being the other. 

Removing the CYG_FAIL is O.K.

         Andrew


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]