Re: [ECOS] New memory allocation debug feature

[Andrew Lunn <andrew at lunn dot ch>]

> > You also need to provide an implementation in libtarget.a for when the
> > application does not have such a function. eg all the test programs
> > will not provide this function, so will fail to link when your new
> > option is enabled. So please add a week function which does nothing,
> > or maybe throws an CYG_FAIL().
> 
> Hmmm... Can this be done without adding a new source file? 

Can you declare a function using C calling convention in a C++ file? I
don't know, im a C programmer. If you can, i suggest you add it to the
end of malloc.cxx

> 
> > It would also be nice if you used to same coding style for the patch
> > as for the rest of the file, ie { on the same line as the if etc.
> 
> Should be OK now.

The patch looks like the indentation is wrong, but that could be that
tabs are being shown wrongly. Once we have a patch with a the we[ea]k
function i will take a closer look.
 
> My dream is that CVS would automatically enforce  all such formatting
> rules transparently, and that text editors would present the source code
> in the preferred coloring and formatting of the programmer. :-)

CVS enforcing it only causes me more problems since i would have to
reject more patches. You should try emacs. It does colouring i like
and once you have told it what formatting style to use it also does
most of the layout work as well.

        Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss