This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
typos in standalone eth_drv
- From: Jani Monoses <jani at iv dot ro>
- To: ecos-discuss at sources dot redhat dot com
- Date: Thu, 11 Jul 2002 14:55:51 +0000
- Subject: [ECOS] typos in standalone eth_drv
It seems harmless the way it is but aren't those tests meant to be like below?
! has precedence over bitwise operations.
Index: io/eth/current/src/stand_alone/eth_drv.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/io/eth/current/src/stand_alone/eth_drv.c,v
retrieving revision 1.17
diff -u -r1.17 eth_drv.c
--- io/eth/current/src/stand_alone/eth_drv.c 23 May 2002 23:06:04 -0000 1.17
+++ io/eth/current/src/stand_alone/eth_drv.c 11 Jul 2002 11:50:54 -0000
@@ -276,7 +276,7 @@
sc->funs->eth_drv_old = sc->funs->eth_drv;
sc->funs->eth_drv = ð_drv_funs; // Substitute stand-alone driver
old_state = sc->state;
- if (!old_state & ETH_DRV_STATE_ACTIVE) {
+ if (!(old_state & ETH_DRV_STATE_ACTIVE)) {
// This interface not fully initialized, do it now
(sc->funs->start)(sc, (unsigned char *)&__local_enet_addr, 0);
sc->state |= ETH_DRV_STATE_ACTIVE;
@@ -388,7 +388,7 @@
sc->funs->eth_drv_old = sc->funs->eth_drv;
sc->funs->eth_drv = ð_drv_funs; // Substitute stand-alone driver
old_state = sc->state;
- if (!old_state & ETH_DRV_STATE_ACTIVE) {
+ if (!(old_state & ETH_DRV_STATE_ACTIVE)) {
// This interface not fully initialized, do it now
(sc->funs->start)(sc, (unsigned char *)&__local_enet_addr, 0);
sc->state |= ETH_DRV_STATE_ACTIVE;
--
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss