Re: [ECOS] flash ROM support for cq7750.

[Jonathan Larmour <jlarmour at redhat dot com>]

Koichi Nagashima wrote:
> 
> Hi, folks,
> 
> Attached patch provides flash ROM support for cq7750.
> 
> This patch modifies and adds some codes as following.
> 1. am29xxxxx codes are slightly modified suite for AM29LV800-B
>    and its compatible chip. This change may work with another
>    am29xxxxx chip, I think.
> 2. a new flash ROM data, Toshiba TC58FVB800, is added to the AMD
>    am29xxxxx family.
> 3. a new flash package for cq7750 paltform is added.

Thanks for this! It's very useful and I agree with the changes you've made
to flash_am29xxxxx.inl after looking at the AMD datasheets, except for one.
It would be good to get this code into eCos, but it requires a copyright
assignment. Can you read http://sources.redhat.com/fom/ecos?file=47 and
fill in the assignment form, disclaimer, and post them to us?
 
> @@ -330,6 +331,8 @@
>                  if (FLASH_BlankValue == state) {
>                      break;
>                  }
> +
> +               if((state & FLASH_Busy) == (*b_v & FLASH_Busy)) break;

I'm not sure about this change. While checking the toggle bit is also a
valid test that the erase operation has completed, why would it be required
if the flash isn't blanked? Should this even replace the test against
FLASH_BlankValue?

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine