Re: [ECOS] TFTP bug

[Jonathan Larmour <jlarmour at redhat dot com>]

Pushparaj wrote:
> 
> Hi Jonathan,
> I am working on motorola powerpc 860 platform and trying to download a 890,338 size
> s19 file.
> It is a s-record. It is built at 2MB in RAM. I am using the load command and I give it
> in this format.
> load c:\image.s19.

You said before you were loading it in "raw" format using -r. Make your
mind up!

> The server ip address is set and the redboot is also able to understand that the
> image.s19 file is built at 2MB. Redboot is not using this address in RAM.
> Now when I try to download I print the server port numbers in functions,
> tftp_stream_read and udp_sendto and udp_recvfrom. I find that the server udp port
> number ie., sin_port is changing to zero sometimes. Why does this happen ?

Curiously, looking at the code in redboot's tftp_client.c, I can't see how
tftp_stream.from_addr gets set at all. I can only assume it has worked
before because all the data has already been sent from the server fast
enough.

I think you'll find it works if near the end of tftp_stream_open (after the
assignment to total_timeouts) you add a:

memcpy(&tftp_stream.local_addr, server, sizeof(*server));

Let us know if that's sufficient to fix the problem for you and I'll apply
it in the main sources.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine