This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001561] Internal flash driver for Freescale TWR-K60N512 board


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1697|                            |assignment?
               Flag|                            |
   Attachment #1697|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #1697|0                           |1
           is patch|                            |

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-12 18:43:07 BST ---
(From update of attachment 1697)
Hi Nicolas

Thank you for your contribution, it would be nice to have Kinetis flash support
in eCos.

In order to include your code in the official eCos repository we need your
copyright assignment. Please visit http://ecos.sourceware.org/assign.html for
explanation of the reasons for copyright assignment as well as the procedure
instructions.

The copyright assignment process will take some time, but in meantime we can
prepare your code for inclusion. Apart from notes below, I would start with
code review as soon as you inform me that you have started with copyright
assignment (that means you have sent materials to FSF).

Now some general notes on your flash driver:

1. I imagine that all Kinetis parts have identical or similar Flash modules so
the driver, especially code, should be common at variant level. Platforms then
would mostly have configuration CDL.

1.a. It would help if you break the patch in several files, typically: driver,
variant, platform, ecos.db, etc). Regarding ecos.db it is sometimes better to
submit packages as plain text file rather than diff.

2. I can notice some temporary files left by your editor. Please try to keep
your code clean.

That's all for now.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]