This is the mail archive of the
ecos-bugs@sourceware.org
mailing list for the eCos project.
[Bug 1001184] Cortex-m arch: hal_intr.h includes var_intr.h tooearly.
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-bugs at ecos dot sourceware dot org
- Date: Sun, 3 Apr 2011 22:03:27 +0100
- Subject: [Bug 1001184] Cortex-m arch: hal_intr.h includes var_intr.h tooearly.
- Auto-submitted: auto-generated
- References: <bug-1001184-13@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001184
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-04-03 22:03:25 BST ---
(In reply on comment #0)
> Created an attachment (id=1195)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1195)
> Include var_intr.h after definition of hal_intr.h macros but allows
> overriding of CYGNUM_HAL_INTERRUPT_RTC.
>
> In Cortex-M architecture, the header hal_intr.h includes var_intr.h
> twice. Second one is of course with no effect, but the first one is
> too early. Namely some macros that are defined in hal_intr.h, such as
> CYGNUM_HAL_INTERRUPT_EXTERNAL, are used in hal-intr.h. This doesn't
> seem to show ill effect so far since usage is by other macros.
>
> Note: The early inclusion of var_intr.h has been introduced by Bug
> 1001090 Attachment 1092 in order to enable overriding of
> CYGNUM_HAL_INTERRUPT_RTC by variant/platform.
>
> The proposed patch includes var_intr.h after definition of hal_intr.h
> macros but also allows overriding of CYGNUM_HAL_INTERRUPT_RTC.
Thanks for catch. On my look CYGNUM_HAL_INTERRUPT_RTC definition became
misplaced lines via that request (no header, in fact). So, I would shift
down the definition and point on this on CL entry. Certainly, the first
inclusion of the header can be removed safely then.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.