This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-29 10:29:19 BST ---
(In reply to comment #6)
> The idea with my naming is to continue macro sequence present already
> in tty.c CYGPKG_IO_SERIAL_TTY_TTY0 .. CYGPKG_IO_SERIAL_TTY_TTY3 then
> CYGPKG_IO_SERIAL_TTY_ADD. Maybe it could be CYGPKG_IO_SERIAL_TTY_PLUS
> or, to emphasis that it is an inline: CYGPKG_IO_SERIAL_TTY_PLUS_INL
> (.inl is also extension for included file).

> Also we could add some comment in front of the macro:
> 
> // CYGPKG_IO_SERIAL_TTY_PLUS_INL macro provides for user inclusion of additional
> // TTY devices. Included file should be typically placed in serial device
> include
> // directory. It should be accompanied by a cdl_component that shall define the
> // macro as well provide as TTY device configuration, as a part of serial device
> // cdl file.

Thank you for the comment lines. But, I would prefer to use CYGDAT
prefix (!CYGPKG), e.g.  CYGDAT_IO_SERIAL_TTY_ADD_INL. Usually CDL
options using 'flavor data' are prefixed with CYGDAT. IMO a line

#include <CYGDAT_IO_SERIAL_TTY_ADD_INL>

looks more preferable than

#include <CYGPKG_IO_SERIAL_TTY_ADD_INL>

If you agree with my point I would update the patch (options names)
(CYGDAT_IO_SERIAL_TTY_ADD_INL, CYGDAT_IO_SERIAL_TERMIOS_ADD_INL) and
expand comment lines there.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]