[Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STKplatform

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114

--- Comment #33 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-07 19:03:59 GMT ---
(In reply to comment #32)

[snip]

> Ilija, I leaved your signals and used self-commented lines there (IMO it
> is more readable) see Attachment 1165 [details]. Please, re-test it and let me
> know about results.

Sergei, Thanks for the patches and descriptive comments. However some OR are
missing in Attachment 1165 (could be corrected in the patch itself):

     CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1,
-                               (1 /* RXD1 */  << 0)
-                               (1 /* CTS1 */  << 2)
-                               (1 /* DCD1 */  << 4)
-                               (1 /* DSR1 */  << 6)
-                               (1 /* DTR1 */  << 8)
+                               (1 /* RXD1 */  << 0) |
+                               (1 /* CTS1 */  << 2) |
+                               (1 /* DCD1 */  << 4) |
+                               (1 /* DSR1 */  << 6) |
+                               (1 /* DTR1 */  << 8) |
                                (1 /* RTS1 */  << 12)

After correction it compiles without warnings.
Unfortunately I am on a trip again so I haven't been able to test runtime. I am
arranging for remote access to our laboratory for Thursday evening.

I am going to submit patch after runtime test.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.