[Bug 1001116] Instruct lwIP to use special section for buffers andheap.

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116

--- Comment #28 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-30 20:54:22 GMT ---
(In reply to comment #27)
> (In reply to comment #26)
> > Well, let's stop on this point of survey. What do you think?
> 
> Seems we came to conclusion. As I understand CYGSEM_LWIP_MEM_SECTION_NAME is
> not in 2 steps (with CYGHWR_HAL_MEM_SECTION_NAME) but simple as before, only
> enclosed in CYGOPT_LWIP_MEM_PLF_SPEC.

I've used "two step" in tested HAL (data option for HWR name and booldata for
LWIP name), but, it's your choice, and "one step" boolean option in lwip CDL:
there was CYGOPT_LWIP_MEM_SECTION in the container CYGOPT_LWIP_MEM_PLF_SPEC 
(See my comment #25) But that was before our "conclusion".

> Something like this?
> 
> --- lwip_net.tcl ---
> 
>     cdl_component CYGOPT_LWIP_MEM_PLF_SPEC {
>         display         "Platform specific memory setting"
>         flavor          none
>         no_define  
>         cdl_option CYGSEM_LWIP_MEM_SECTION {
>             display "Place lwIP buffers and heap in special memory section."
>             flavor bool
>             default_value 1
>             active_if CYGDAT_LWIP_MEM_SECTION_NAME
>             description "..."
>        }
>    }

Ups, as I could understand your latest thing was

    default_value is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
    active_if     CYGDAT_LWIP_MEM_SECTION_NAME

I'm starting to hate patch-review througout $BROWSER, I am again in a mess. Do
you *tested* this

    cdl_option CYGOPT_LWIP_MEM_SECTION {
        default_value 1
        active_if CYGDAT_LWIP_MEM_SECTION_NAME

or this one

    cdl_option CYGOPT_LWIP_MEM_SECTION {
        default_value is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
        active_if     CYGDAT_LWIP_MEM_SECTION_NAME

Ilija, please, attach your latest and *tested* patch for review.

> --- hal...cdl example---
> 
>     cdl_option CYGDAT_LWIP_MEM_SECTION_NAME {
>         flavor data
>         active_if CYGPKG_NET_LWIP
>         parent CYGOPT_LWIP_MEM_PLF_SPEC
>         default_value { "\".ahb_bss\"" }
>         legal_values { "\".ahb_bss\"" "\".ahb_0\"" }
>         display "Memory section for lwIP buffers."
>         description " ... Sections are provided by LPC17xx platform HAL." 
>     }

I see you prefer "one step" assigned, this is your choice and this for
Bugzilla 1001114.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.