[Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STKplatform

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-18 01:48:19 GMT ---
(In reply to comment #6)
> Hi,
> 
> First, Ilija, thank you for your contribution.

Thanks for the review Sergei.

> 
> [RFC to reviewers]
> 
> As NXP does "copy and paste" own "PrimeCell" registers from a design
> to design (what is generally speaking is good for programmers) we can
> observe the same interference the device drivers  in a code each other
> (e.g. lpc2xxx, lpc24xx and now lpc17xx). New Ilija's port for lpc17xx is
> a good example such an interference and how the hackers would deal with
> "PrimeCell" registers to reuse the code.
> 

[snip]

> 
> Pros: code reuse, code reuse, code reuse.
> 

[snip]

> Cons: code interference, "difficult" to understand HAL, the bloches of
> "foreigners" in the target definition (see attachment 1078 [details]).
> 

[snip]

> Well, I see new "Cons" in my proposal: code duplication, code duplication,
> code duplication :-) Maybe someone found a better solution? And maybe
> my fears are baseless at all? Then forget it, please.

Sergei

I had the same dilemma but I found out that peripherals are so compatible, eCos
so well structured and Uwe's (and other's) work so good that coupling LPC42xx
drivers with LPC17xx went with very little intervention from my side - they
love each other. I merely introduced them by submitting LPC17xx base addresses.
And I think in this case it pays off and should be considered for other
peripherals.
One point: please note that the real UART work is done by generic 16x5x driver
that is shared among myriad of devices and architectures.

I did the opposite for HAL diagnostic drivers by grafting LPC24xx code onto
STM32 template (and taking the credits :) ).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.