[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add pr24171.sh test-case
On Sat, Mar 16, 2019 at 03:25:19AM +0100, Tom de Vries wrote:
> Hi,
>
> Add test-case for PR24171, using dw2-restrict.S from binutils-gdb repo.
>
> OK for trunk?
>
> Thanks,
> - Tom
>
> Add pr24171.sh test-case
>
> 2019-03-16 Tom de Vries <tdevries@suse.de>
>
> * Makefile (TEST_EXECS): Add dw2-restrict.
> (dw2-restrict): New target.
> * dw2-restrict.S: New file, copied from binutils-gdb repo.
> * testsuite/dwz.tests/dwz-tests.exp: Require dw2-restrict for
> pr24171.sh.
> * testsuite/dwz.tests/pr24171.sh: New test.
I just wonder if the test shouldn't be either in testsuite/dwz.tests/
or testsuite/dwz.tests/pr24171/ subdirectory. It would be better
if the toplevel directory contained just the sources and whatever is needed
to build them, plus testsuite subdirectory.
Otherwise LGTM.
Jakub