Re: ushort definition

[Marco Atzeri <marco dot atzeri at gmail dot com>]

On 09/01/2017 23:30, Hans-Bernhard Bröker wrote:
> Am 09.01.2017 um 20:46 schrieb Marco Atzeri:
> > On 09/01/2017 19:01, Hans-Bernhard Bröker wrote:
>
>
> > the "#define ushort unsigned short" is in the
> > /usr/include/jasper/jas_config.h
> >
> > It seems jasper configuration had not defined __MISC_VISIBLE,
> > while gdal does.
>
> Neither is supposed to #define __MISC_VISIBLE itself.  cscope finds:
>
> $ cscope -dL1 __MISC_VISIBLE
> /usr/include/sys/features.h __MISC_VISIBLE 276 #define __MISC_VISIBLE 1
> /usr/include/sys/features.h __MISC_VISIBLE 278 #define __MISC_VISIBLE 0
>
> So let's look at a bit of context:
>
> $ sed -n -e '270,280p' /usr/include/sys/features.h
> #define __LARGEFILE_VISIBLE     1
> #else
> #define __LARGEFILE_VISIBLE     0
> #endif
>
> #ifdef _DEFAULT_SOURCE
> #define __MISC_VISIBLE          1
> #else
> #define __MISC_VISIBLE          0
> #endif
>
> I.e. if jasper didn't have __MISC_VISIBLE on, it must have overridden
> the default feature test state of _DEFAULT_SOURCE.

I will bet on a "-std=C99" somewhere

> The lesson to be had from all this: #defining types is just wrong. Don't
> do it.  typedef exists to be used.

Thanks again
Marco





--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple