This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 1.7.33-0.4


Corinna Vinschen wrote:
I just released a 4th TEST version of the next upcoming Cygwin release,
1.7.33-0.4.

There is an older regression in mkgroup.
A separator without a preceding domain name is printed for the builtin groups:

$ mkgroup -L THISHOST
SYSTEM:S-1-5-18:18:
TrustedInstaller:S-1-5-80-...
+Administratoren:S-1-5-32-544:544:
+Benutzer:S-1-5-32-545:545:
...
THISHOST+HelpLibraryUpdaters:S-1-5-21-...


Introduced in mkgroup.c CVS 1.54, April 2014:

@@ -415,8 +341,8 @@ enum_local_groups (...)
...
          printf ("%ls%s%ls:%s:%" PRIu32 ":\n",
-                 with_dom && !is_builtin ? domain_name : L"",
-                 with_dom && !is_builtin ? sep : "",
+                 mach->with_dom && !is_builtin ? domain_name : L"",
+                 mach->with_dom || is_builtin ? sep : "", <==== Hmm.... :-)


BTW: mkgroup should possibly also print the extra builtin groups which are now reported by getgroups(), for example 4(Interactive), 11(Authenticated Users), ...
Groups with variable SIDs like LogonSession are an exception.

Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]