This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bash 2.05 vs. 3.0 Prompt Behavior [attn readline maintainer]


>> Hi Eric,
>> 
>> I fixed this minor issue (so I believe) in my early attempts in
>> becoming a bash maintainer sometime in april this year.
>> I've attached a patch file (based on bash-3.0-7).
>> 
>> greets,
>> H.

Hans was kind enough to provide me his proposed patch offlist, which
boils down to this:

--- bash-3.0/lib/readline/display.c     2005-07-06 05:59:59.000000000 -0600
+++ bash-3.0/lib/readline/display.c     2005-07-09 07:57:13.632987200 -0700
@@ -269,6 +269,7 @@
                }
              else
                ninvis++;               /* invisible chars byte counter */
+               last++;
            }

          if (invflset == 0 && rl >= _rl_screenwidth)

But I have some questions about it.  First, Hans, did you forget some {}
so that the increment of last occurs only on the else block, or else
why did you indent it at the same level?  Second, this is in a readline
file, so do you want to look closer at it, Charles?

--
Eric Blake



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]