This is the mail archive of the
cygwin-xfree
mailing list for the Cygwin XFree86 project.
Re: PATCH: Fix mwextwm mode to build again
- From: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- To: cygwin-xfree at cygwin dot com
- Date: Fri, 23 Jan 2009 12:49:08 +0000
- Subject: Re: PATCH: Fix mwextwm mode to build again
- References: <49308030.60401@dronecode.org.uk> <497444D5.3080507@users.sourceforge.net>
- Reply-to: cygwin-xfree at cygwin dot com
Yaakov (Cygwin/X) wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Jon TURNEY wrote:
This fixes multiwindow external window manager('-mwextwm') mode to build
again.
Note this depends on Apple's Xplugin.h to build the rootless extension
(just for some typedefs I think), which is no longer included in the
X.Org tree, as an old version once was.
Thank you Jon and Colin for the patch. A few questions:
1) The ROOTLESS_WORKAROUND define only affects one place, namely
miext/damage/damage.c:getDrawableDamageRef(). What does this do
exactly, and what affect may it have on modes other than -mwextwm?
$ git blame miext/damage/damage.c -L /ROOTLESS/,+3
d7fef522 (Kevin E Martin 2004-09-02 04:04:47 +0000 93) #ifdef ROOTLESS_WORKAROUND
b2135e58 (Kevin E Martin 2004-09-03 16:18:23 +0000 94) &&
((WindowPtr)pDrawable)->viewable
d7fef522 (Kevin E Martin 2004-09-02 04:04:47 +0000 95) #endif
$ git log -1 d7fef522
commit d7fef52254126aa5897a5c58faeda1f61d5b13d8
Author: Kevin E Martin <kem@kem.org>
Date: Thu Sep 2 04:04:47 2004 +0000
Workaround for servers using rootless layer with damage (Bug #1168, Torrey
T. Lyons).
$ git log -1 b2135e58
commit b2135e589baeb2ea26da50b9167feaea23bcce3c
Author: Kevin E Martin <kem@kem.org>
Date: Fri Sep 3 16:18:23 2004 +0000
First set of documentation updates.
Include more correct fix for rootless interaction with damage (Bug #1168,
Keith Packard).
http://bugs.freedesktop.org/show_bug.cgi?id=1168
2) Why delete the RootlessAccelInit call in
hw/xwin/winscrinit.c:winFinishScreenInitFB()?
As I recall, that code has been disabled in the 1.5.x tree, so we can't call
it. I think I noticed that it's recently been turned back on by the Apple
guys in git master.
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://x.cygwin.com/docs/
FAQ: http://x.cygwin.com/docs/faq/