This is the mail archive of the
cygwin-xfree@cygwin.com
mailing list for the Cygwin XFree86 project.
Re: xterm-186 build bustage
On Sat, 24 Apr 2004, Thomas Dickey wrote:
> On Sat, 24 Apr 2004, Igor Pechtchanski wrote:
>
> > > You'll quickly note that 'X.Org Foundation' is somehow
> > > getting into CFLAGS as a raw string, causing gcc to bork. It seems that
> > > this may be somehow caused by macros in xterm's configure scripts that
> > > copy the CFLAGS set by the imake configuration files.
>
> > However, with the CVS version I did get a "too many decimal points in a
> > number" error. I suspect it's a quoting issue -- XVERSION should have
> > been defined as a string, and it was missing the quotes. An extra level
> > of shell invocation probably stripped them out. I'll investigate...
>
> That seems to be a lesser problem (still not a very good idea).
>
> Actually the problem as reported seems to be
> X11.tmpl:96:#define VendorDefines -DXVENDORNAME='"$(VENDORNAME)"' -DXVENDORNAMESHORT='"$(VENDORNAMESHORT)"'
>
> which would work better if it were
>
> X11.tmpl:96:#define VendorDefines -DXVENDORNAME=\"$(VENDORNAME)\" -DXVENDORNAMESHORT=\"$(VENDORNAMESHORT)\"
>
> since the quotes otherwise are not echoed.
Well, IMO, it's the same problem, just a different incarnation:
xc/programs/xterm/Imakefile:117: XVERSIONDEFS = -DXVERSION='"4.3.99.3"'
should have been
xc/programs/xterm/Imakefile:117: XVERSIONDEFS = -DXVERSION=\"\\\"4.3.99.3\\\"\"
(you actually need both sets of quotes so that the inner double quotes get
propagated to gcc -- same goes for your proposed changes above, and,
possibly, for the true clause of the #if statement in the above
Imakefile). If it helps, I can submit a proper patch instead.
FWIW, since I only checked out the xc/programs/xterm directory, not the
whole X tree, I was missing the config files (including X11.tmpl). I
assume that's why I was unable to reproduce Harold's problem, since he
probably has the whole tree, and his build was actually picking up the
(unquoted) values of the variables. As a side question, what's the
minimal set of files that needs to be checked out from CVS to build just
xterm/resize?
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster." -- Patrick Naughton