This is the mail archive of the
cygwin-xfree@cygwin.com
mailing list for the Cygwin XFree86 project.
Re: Proper attribution of patches
- From: Alan Hourihane <alanh at fairlite dot demon dot co dot uk>
- To: cygwin-xfree at cygwin dot com
- Cc: devel at xfree86 dot org
- Date: Tue, 23 Dec 2003 20:49:19 +0000
- Subject: Re: Proper attribution of patches
- References: <200312222110.hBMLAPRo087003@public.xfree86.org> <3FE888B0.2020503@msu.edu> <Pine.BSI.4.53.0312231401400.5858@mail.his.com>
- Reply-to: cygwin-xfree at cygwin dot com
On Tue, Dec 23, 2003 at 02:02:20PM -0500, Thomas Dickey wrote:
> On Tue, 23 Dec 2003, Harold L Hunt II wrote:
>
> > The following CVS commit, made by Thomas Dickey, has no indication that
> > Thomas was either a) not involved at all in the patch or b) that Thomas
> > found Ralf Habacker's patch and committed a modified version of that patch.
> >
> > The CVS log message says:
> > fixes for _XtInherit on cygwin.
> >
> > The hw/xfree86/CHANGELOG files says:
> > XFree86 4.3.99.903 (xx December 2003)
> > + 699. Fixes to build/run on cygwin (Thomas Dickey).
> >
> > I know that this patch was based at least in part (if not entirely) on
> > Ralf Habacker's patch for the same, since it includes a more than twenty
> > line comment from Ralf along with his name at the bottom:
> >
> > http://cvsweb.xfree86.org/cvsweb/xc/lib/Xt/Initialize.c.diff?r1=3.21&r2=3.22&f=h
>
> I'm aware of that.
>
> Your commit didn't mention this either. Do you have point?
Thomas,
If you did get this code directly from Cygwin/X's tree then I'd of
expected at least the credit to be apportioned to Harold at the very
least, rather than putting your name against it. Ralf's name could have
been corrected later, with a follow email from Harold.
It's a simple change to put that right in the CHANGELOG. So I'll do that.
Alan.