This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH 06/11] Remove always true nonnull check on "this" pointer.
- From: Peter Foley <pefoley2 at pefoley dot com>
- To: cygwin-patches at cygwin dot com
- Cc: Peter Foley <pefoley2 at pefoley dot com>
- Date: Tue, 29 Mar 2016 16:49:29 -0400
- Subject: Re: [PATCH 06/11] Remove always true nonnull check on "this" pointer.
- Authentication-results: sourceware.org; auth=none
- References: <1458409557-13156-1-git-send-email-pefoley2 at pefoley dot com> <1458409557-13156-6-git-send-email-pefoley2 at pefoley dot com>
On Sat, Mar 19, 2016 at 1:45 PM, Peter Foley <pefoley2@pefoley.com> wrote:
> G++ 6.0 can assert that the this pointer is non-null for member functions.
>
> winsup/cygserver/ChangeLog
> process.cc (submission_loop::request_loop): Remove nonnull check on this.
> process.cc (sync_wait_array): Ditto.
> process.cc (check_and_remove_process): Ditto.
> threaded_queue.cc (add_submission_loop): Ditto.
> threaded_queue.cc (add): Ditto.
> threaded_queue.cc (start): Ditto.
> threaded_queue.cc (stop): Ditto.
>
> winsup/cygwin/ChangeLog
> fhandler_dsp.cc (Audio_out::buf_info): Remove nonnull check on this.
> fhandler_dsp.cc (Audio_in::buf_info): Ditto.
> path.cc (fcwd_access_t::Free): Ditto.
> pinfo.cc (_pinfo::exists): Ditto.
> pinfo.cc (_pinfo::commune_request): Ditto.
> pinfo.cc (_pinfo::pipe_fhandler): Ditto.
> pinfo.cc (_pinfo::fd): Ditto.
> pinfo.cc (_pinfo::fds): Ditto.
> pinfo.cc (_pinfo::root): Ditto.
> pinfo.cc (_pinfo::cwd): Ditto.
> pinfo.cc (_pinfo::cmdline): Ditto.
> signal.cc (_pinfo::kill): Ditto.
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
> winsup/cygserver/process.cc | 3 ---
> winsup/cygserver/threaded_queue.cc | 4 ----
> winsup/cygwin/fhandler_dsp.cc | 4 ++--
> winsup/cygwin/path.cc | 2 +-
> winsup/cygwin/pinfo.cc | 16 ++++++++--------
> winsup/cygwin/signal.cc | 2 +-
> 6 files changed, 12 insertions(+), 19 deletions(-)
I got the copyright assignment form back, so this can now be reviewed
and hopefully merged.
Thanks,
Peter Foley