This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cygwin: define byteswap.h inlines as macros


On 2016-03-15 04:03, Corinna Vinschen wrote:
On Mar 14 22:13, Yaakov Selkowitz wrote:
The bswap_* "functions" are macros in glibc, so they may be tested for
by the preprocessor (e.g. #ifdef bswap_16).
ACK.

While we're at it, what about converting the types to implicit types
(__uint16_t, __uint32_t, __uint64_t).

glibc uses short/int/long long for these, so I think we should leave them.

Also, do we want to convert the inline code to use the x86 bswap instructions?

Possibly, but SHTDI.

--
Yaakov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]