Re: [PATCH] Support profiling of multi-threaded apps.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Mar 10 10:39, Corinna Vinschen wrote:
> On Mar 10 00:35, Mark Geisert wrote:
> > This is Version 4 incorporating review comments of Version 3.  This is just
> > the code patch; a separate doc patch is forthcoming.
> 
> Uhm...
> 
> > +		long divisor = 1000*1000*1000; // covers positive pid_t values
> 
> ...still "long"?
> 
> Was that an oversight or did you decide to keep it a long?  Either way,
> no reason to resend another patch version.  If you want an int32_t here,
> I fix that locally before pushing the patch.

Oh, btw., do you have a sentence or two for the release text?  Just
a short description what's new or changed or fixed.  Have a look at
winsup/cygwin/release/2.5.0 for an informal howto.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature