This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C99 assert


On Jun 26 18:59, Eric Blake wrote:
> > 	Support __func__ in assert, as required by C99.
> > 	* libc/stdlib/assert.c (__assert_func): New function.
> > 	(__assert): Use __assert_func.
> > 	* libc/include/assert.h (assert) [!NDEBUG]: Use __assert_func when
> > 	possible.
> 
> If I check in just the above newlib patch, CVS cygwin will be broken when
> trying to use assert (and simply exporting __assert_func won't help, since
> cygwin's assert.cc must provide all symbols present in newlib's assert.c).
>  Likewise, this patch without newlib would break (because assert.h is
> maintained by newlib).  So, is it OK to apply this patch at the same time
> as the newlib patch, to avoid breakage?
> 
> 2007-06-26  Eric Blake
> 
> 	* assert.cc (__assert_func): New function, to match newlib header
> 	change.
> 	* cygwin.din: Export __assert_func.
> 	* include/cygwin/version.h: Bump API minor number.

Yeees, barely.  This is on the verge of being non-trivial, however.
Any chance you can sign the copyright assignment?  Please?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]